width and height bindings #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich-Harris
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 91.19% 91.21% +0.01%
==========================================
Files 122 122
Lines 4465 4484 +19
Branches 1377 1384 +7
==========================================
+ Hits 4072 4090 +18
Misses 156 156
- Partials 237 238 +1
Continue to review full report at Codecov.
|
|
Do we get an |
|
afraid not! just the bindings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #984.
Progress is blocked by #1385 so I'll merge thatThis turned out well. One wrinkle: it doesn't work with SVG elements (other than
<svg>itself) — not sure if there's a clever alternative.